Skip to content

Conversation

@scouturier
Copy link
Contributor

@scouturier scouturier commented Apr 17, 2025

Issue number:

Summary

Adding AWS Location MCP server to allow LLM models interact with AWS Location to get coordinates

Changes

Adding AWS Location MCP server to allow LLM models interact with AWS Location to get coordinates

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@scouturier scouturier requested review from a team as code owners April 17, 2025 15:38
@scouturier scouturier changed the title Adding AWS Location MCP server feat: Adding AWS Location MCP server Apr 17, 2025
Copy link
Member

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see the contribution! Minor details to remediate. Thank you!

@scottschreckengaust
Copy link
Member

We are using uv in our builds. Could you post a uv.lock file along with your MCP server? Thank you!

@scouturier
Copy link
Contributor Author

Fixed! Let me know if there is anything else missing!

@scottschreckengaust scottschreckengaust added the hold-merging Signals to hold the PR from merging label Apr 17, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 83.47339% with 59 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (36e8a20) to head (0b34aa3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n-mcp-server/awslabs/aws_location_server/server.py 83.42% 36 Missing and 23 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   77.59%   77.91%   +0.32%     
==========================================
  Files          73       75       +2     
  Lines        6087     6444     +357     
  Branches     1041     1099      +58     
==========================================
+ Hits         4723     5021     +298     
- Misses        966     1002      +36     
- Partials      398      421      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottschreckengaust scottschreckengaust added the new mcp server A new MCP server ideally linked to an issue label Apr 28, 2025
theagenticguy
theagenticguy previously approved these changes May 7, 2025
theagenticguy
theagenticguy previously approved these changes May 7, 2025
Copy link
Member

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scouturier - this is getting very close.

scouturier and others added 2 commits May 7, 2025 12:38
…ation-mcp-server Dockerfile and update test credentials
@scottschreckengaust scottschreckengaust removed the hold-merging Signals to hold the PR from merging label May 7, 2025
theagenticguy
theagenticguy previously approved these changes May 7, 2025
Copy link
Member

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theagenticguy theagenticguy added this pull request to the merge queue May 7, 2025
Merged via the queue into awslabs:main with commit 79562e1 May 7, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new mcp server A new MCP server ideally linked to an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants